On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Avoids duplicating the code. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > Cc: Sonika Jindal <sonika.jindal@xxxxxxxxx> > Cc: Damien Lespiau <damien.lespiau@xxxxxxxxx> > --- > Can we do this? Sure, but I'd like to see update_primary_plane split into two in that case. One to precalcuate the parameters, then the second to apply them as we skip the first here (due to doing the setup in process context) and want the second to run inside the vblank evasion logic (and the unbounded nature of the current update_primary_plane logic scares me). -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
