Re: [PATCH v2 7/8] drm/i915: Move toggling planes out of crtc enable/disable.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 16, 2015 at 12:26:52PM +0200, Maarten Lankhorst wrote:
> This makes disabling planes more explicit.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> ---
> Changes since v1:
> - Create a intel_crtc_reset function for i915_debugfs.c instead of calling .crtc members directly.
> - Remove the checks for intel_crtc->active, they're wrong. (thanks anderco)

Style recommendation in drm/i915 land is to put the per-patch changelog
before the cutoff. I know that often it contains just noise, but often the
commit message doesn't get updated with the new reasonings and these
breadcrumbs tend to be really valuable when trying to understand why a
patch was done in the future.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux