On su, 2015-04-12 at 16:02 +0530, sagar.a.kamble@xxxxxxxxx wrote: > These are review comments for > 1) http://lists.freedesktop.org/archives/intel-gfx/2015-March/062167.html > 2) http://lists.freedesktop.org/archives/intel-gfx/2015-March/062168.html It'd be better to have inlined review comments responding to the original email. > Couple of comments: > 1) Defines for DC_STATE_EN* are coming up as part of > http://lists.freedesktop.org/archives/intel-gfx/2015-April/063640.html. > Need to rebase this patch on top of it then or vice-versa. Yes, I can rebase this once Animesh's patchset gets merged. It's also a trivial conflict that can be easily resolved while merging, so it's not an issue imo. > 2) DC5 has to enabled back after disabling DC9 if PW2 is power gated. BXT DC5/runtime PM support will be added only later. At that point the enabling of DC5 should be done from bxt_resume_prepare() if the the DMC firmware is loaded. For now I'd just add the missing TODO comment about this to bxt_resume_prepare() as you suggested elsewhere. --Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
