Re: [PATCH 04/13] drm/i915/gen8: Add dynamic allocation macros and helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 08, 2015 at 12:13:26PM +0100, Michel Thierry wrote:
> +static inline uint32_t gen8_pml4e_index(uint64_t address)
> +{
> +	BUG(); /* For 64B */

Please never use BUG where a WARN would do too. Fixed while applying.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux