On Wed, Apr 01, 2015 at 11:17:32AM +0300, Ander Conselvan De Oliveira wrote: > On Tue, 2015-03-31 at 15:26 +0200, Daniel Vetter wrote: > > On Tue, Mar 31, 2015 at 11:35:00AM +0300, Ander Conselvan de Oliveira wrote: > > > The best_encoder field of connector_state wasn't properly set when a > > > connector was being disabled, leading to an incosistent atomic state. > > > > > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx> > > > > How does this typically blow up, i.e. commit message is a bit too terse > > imo. Still, applied to dinf for now. > > Yeah, I should have been more verbose on this one. > > For now, this doesn't cause anything to blow up, because everywhere > we're using connector_state->best_encoder there is a check for > connector_state->crtc which is properly initialized. I reached the issue > while testing some patches I haven't sent out yet, that remove the usage > of intel_connector->new_encoder from check_digital_port_conflicts(). In > that case, it would be possible to trigger the converted version of the > WARN in that function. Thanks, added and moved the patch from dinf to dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
