On Thu, Mar 26, 2015 at 12:41:24PM -0700, yu.dai@xxxxxxxxx wrote: > From: Sagar Kamble <sagar.a.kamble@xxxxxxxxx> > > Need to take forcewake before GuC loading. Please explain why and how things fall over if we're not doing this. -Daniel > > Issue: VIZ-4884 > Change-Id: Ie422fc1e122933b161ff63cab23622197e6bba54 > Signed-off-by: Sagar Kamble <sagar.a.kamble@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_guc_loader.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c > index 7c33cc5..4ae9e84 100644 > --- a/drivers/gpu/drm/i915/intel_guc_loader.c > +++ b/drivers/gpu/drm/i915/intel_guc_loader.c > @@ -273,6 +273,7 @@ static int guc_load_ucode(struct drm_device *dev) > int ret; > > WARN_ON(!mutex_is_locked(&dev->struct_mutex)); > + intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL); > > ret = i915_gem_obj_ggtt_pin(guc_fw->uc_fw_obj, 0, 0); > if (ret) > @@ -326,6 +327,8 @@ out: > if (pinned) > i915_gem_object_ggtt_unpin(guc_fw->uc_fw_obj); > > + intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL); > + > return ret; > } > > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
