On Thu, Mar 26, 2015 at 12:22:07PM -0700, Rodrigo Vivi wrote:
> Let userspace know the status of Panel Self-Refresh by virtue of a
> property on the appropriate connector.
>
> v2: Only attach the property if the driver is capable of PSR.
> v3: Add docbook courtesy of Damien.
> v4: Mark the initial value as 'unsupported' - it will be determined
> correctly when we later read the DCPD from the panel.
> v5: Done by Rodrigo:
> - Add disabled state to match all cases
> - Attach it anyway to eDP since it is started as unsupported
> - Change prop name to PSR
> - Add enum to make states more clear
> - Rebased on intel_psr.c changing func name and fixing states
> v6: Done by Rodrigo:
> - Revert name to Panel Self-Refresh
> - Only report Enable/Disable since Active/Exit change so rapidily
> triggering many uevents as Chris pointed out.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Damien Lespiau <damien.lespiau@xxxxxxxxx>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
Looks good to me,
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
We probably want to teach
drm_object_set_value() { if (property == NULL) return -EINVAL; }
but it is safe enough to call with a NULL property, that guard would
just short-circuit the search for an impossible property.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
