Re: [PATCH] drm/i915/skl: Fix up positive error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/24/2015 01:16 PM, Jani Nikula wrote:
On Tue, 24 Mar 2015, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

It should have been negative since it is returned with ERR_PTR().

Please always reference the commit that introduced the issue.

Is there some more precisely defined criteria for "always"?

In this case this is at the moment dead code freshly merged to -nightly only so ideally it would even be better to fix it up in the original patch if possible?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux