Re: [PATCH] tests/kms_psr_sink_crc: Make render visible to human eyes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 20, 2015 at 05:43:40PM +0000, Vivi, Rodrigo wrote:
> On Fri, 2015-03-20 at 10:54 +0100, Daniel Vetter wrote:
> > On Thu, Mar 19, 2015 at 06:24:24PM -0700, Rodrigo Vivi wrote:
> > > This will allow manual tests when crc isn't available.
> > > 
> > > v2: Remove unused and non-sense buf->size and decrease buf->stride a bit as suggested by Daniel.
> > 
> > buf->size isn't nonsense really, it does seem to match what we've
> > allocated. But it also seems unused in the rendercpy functions I've
> > checked. Imo you should keep that line
> 
> oh sure, bad phrase.... the value 4 was nonsense.
> But if I increases that it fails. Without setting it works.
> What do you think?

If just keeping that line makes the test work there's something _really_
fishy going on. If it persists after git clean -dfx and full recompile I'd
dig into it, since this really doesn't make sense.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux