On Thu, Mar 19, 2015 at 05:46:13PM +0100, Daniel Vetter wrote: > On Thu, Mar 19, 2015 at 05:57:12PM +0200, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > @@ -1332,7 +1167,7 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data, > > } > > > > intel_plane = to_intel_plane(plane); > > - ret = intel_plane->update_colorkey(plane, set); > > + intel_plane->ckey = *set; > > I really liked this and wanted to merge, but then realized that this hunk > removes the update for the ioctl. I think we need to put and update_plane > call or similar in here? Doh. Yeah meant to add that and just forgot. I'll respin. > > Also we still have the RMW for the sprite control register - aren't we > know at a point where there's nothing left to keep? See the next patch. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
