On Thu, 19 Mar 2015, "Daniel, Thomas" <thomas.daniel@xxxxxxxxx> wrote:
>> - if (&request->list == &ring->request_list)
>> + /* It should always be possible to find a suitable request! */
>> + if (&request->list == &ring->request_list) {
>> + WARN_ON(true);
>> return -ENOSPC;
>> + }
> Don’t we normally say
> if (WARN_ON(&request->list == &ring->request_list))
> return -ENOSPC;
Yes, particularly since we've amended WARN_ON within i915 to print out
the condition that failed. "true" is not very useful with that. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
