Re: [PATCH] drm/i915: remove indirection in the PCI ID macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 03, 2015 at 01:36:00PM +0000, Damien Lespiau wrote:
> On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote:
> > Spell all the PCI IDs out to be able to quickly grep for the IDs. No
> > functional changes.
> > 
> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> > 
> > ---
> > 
> > I tested this by comparing the results of
> > 
> > $ make drivers/gpu/drm/i915/i915_drv.s
> > $ make arch/x86/kernel/early-quirks.s
> > 
> > before and after the patch. No change.
> 
> I'm sold by the test so:
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx>

Jani just pinged me about this and I agree grepability is nice and bdw is
indeed the odd one out right now. I've added GT1/2 comments so that we
don't just drop that information on the floor and merged it to dinq. Minor
conflict but I think wiggle did the right thing ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux