Re: [PATCH 1/2] drm/i915: Move drm_framebuffer_unreference out of struct_mutex for flips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 11:43:10AM +0000, Tvrtko Ursulin wrote:
> On 02/16/2015 02:31 PM, Chris Wilson wrote:
> >intel_user_framebuffer_destroy() requires the struct_mutex for its
> >object bookkeeping, so this means that all calls to
> >drm_framebuffer_reference must be held without that lock.
> 
> Maybe "drm_framebuffer_unreference must be made without that lock", hm,
> actually "requires the struct_mutex" is misleading, should be "will
> grab/take struct_mutex".

I've changed the commit message to "... must not hold that lock."
> 
> But code itself:
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Both merged, thanks.
-Daniel

> 
> Regards,
> 
> Tvrtko
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux