On Tue, Mar 10, 2015 at 09:23:54AM +0530, sonika wrote: > > On Monday 09 March 2015 02:16 PM, Daniel Vetter wrote: > >On Mon, Mar 09, 2015 at 08:33:27AM +0530, sonika wrote: > >>On Thursday 05 March 2015 06:24 PM, Daniel Vetter wrote: > >>>On Thu, Mar 05, 2015 at 02:51:26PM +0530, Sonika Jindal wrote: > >>>>Signed-off-by: Sonika Jindal <sonika.jindal@xxxxxxxxx> > >>>Imo this needs a little more commit message, and more important it needs > >>>igt test coverage. Best approach there is probably to take the plane test > >>>we have already and extend it to the primary plane. > >>>-Daniel > >>This is just to take care of the case when the size of the fb is smaller > >>than the crtc. > >>I have extended the rotation test (yet to be posted), to create a smaller > >>primary plane fb to be used for 90/270 rotation. > >> > >>Since we still set position to 0 for primary plane, I did not add any test > >>case for positioning of primary plane. > >>That can be added as a separate activity when positioning support is added. > >>Right now this is just to allow smaller fb for primary plane which is > >>possible with universal planes gen >=9. > >Through universal planes it's already possible to position any plane > >anywhere, and this code is all that makes sure this doesn't happen for the > >primary plane. Since you've just changed that I think this needs a > >testcase in igt. > > > >Or maybe I missed something and it's indeed not yet possible to do this? > >-Daniel > Yes, it isn't possible yet. We set the position to 0 in > skylake_update_primary_plane. Hm indeed. But with your patch we no longer reject plane updates for the primary plane which aren't positioned at 0,0. So there's now a bug. I guess either go the full way towards implementing universal plane support on skl (and fix up the hw programming) or we need to wait with this patch a bit more. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
