Re: [PATCH] drm/i915: Do both mt and gen6 style forcewake reset on ivb probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 27 Feb 2015, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Feb 27, 2015 at 06:11:09PM +0200, Mika Kuoppala wrote:
>> commit 05a2fb157e44 ("drm/i915: Consolidate forcewake code")
>> failed to take into account that we have used to reset both
>> the gen6 style and the multithreaded style forcewake registers.
>> This is due to fact that ivb can use either, depending on how the
>> bios has set up the machine.
>> 
>> Mimic the old semantics before we have determined the correct variety
>> and reset both before the ecobus probe.
>> 
>> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> Cc: Huang Ying <ying.huang@xxxxxxxxx>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
>
> Lgtm, do we have a reference for the testing scenario that blew up?
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Pushed to drm-intel-fixes, thanks for the patch and review.

BR,
Jani.

> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux