On Tue, Mar 03, 2015 at 06:25:27PM +0530, akash goel wrote: > On Fri, Feb 20, 2015 at 11:15 PM, Michel Thierry > > + pdp = ppgtt->pml4.pdps[i]; > > + if (!pdp->daddr) > > + pci_unmap_page(hwdev, pdp->daddr, PAGE_SIZE, > > + PCI_DMA_BIDIRECTIONAL); > > + > > For consistency & cleanup, the call to pci_unmap_page can be replaced > with i915_dma_unmap_single. > Same can be done inside the gen8_ppgtt_unmap_pages_3lvl function also. Everything but the dma api interfaces (dma_unmap_page) is deprecated. A follow-up patch to go through all the i915 code and do these replacements would be nice. After all this landed ofc. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
