On Fri, Feb 27, 2015 at 08:51:39PM +0200, Ville Syrjälä wrote: > On Fri, Feb 27, 2015 at 07:47:46PM +0100, Daniel Vetter wrote: > > On Fri, Feb 27, 2015 at 08:21:07PM +0200, Ville Syrjälä wrote: > > > On Fri, Feb 27, 2015 at 08:54:19AM -0800, Matt Roper wrote: > > > > Move watermark handling from intel_pm.c to intel_wm.c and add a little > > > > bit of kerneldoc to exported functions. We also add a new > > > > intel_init_wm() function to setup memory timing information and > > > > initialize the relevant watermark vfuncs. > > > > > > How about delaying gratious code movement until a bunch of the in flight > > > WM stuff has landed? This is just going to cause rebase pains all over. > > > > Hand-editing diffs works reasonable well ime for these kinds of extraction > > patches. At least that's how I've done it with -internal. And git rebase > > can sometimes help too if you crank up the rename detection threshold. > > All pointless extra work. Moving the code doesn't make it any better so > I fail to see why it needs to be rushed in. File extraction is for kerneldoc, because kerneldoc sucks. I agree it doesn't really make the code itself better. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
