On 02/24/2015 09:53 PM, Daniel Vetter wrote:
On Mon, Feb 23, 2015 at 03:57:43PM +0000, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Starting with Skylake the display engine can scan out Y tiled objects. (Both
legacy Y tiled, and the new Yf format.)
This series takes the original work by Damien Lespiau and converts it to use the
new frame buffer modifiers instead of object set/get tiling. Some patches needed
to be dropped, some added and some refactored.
v2: Refactored for fb modifier changes.
Damien Lespiau (7):
lib: Extract igt_buf_write_to_png() from gem_render_copy
lib/skl: Add gen9 specific igt_blitter_fast_copy()
lib: Don't give a struct igt_buf * to fast_copy_pitch()
lib: Split two helpers to build fast copy's dword0 and dword1
lib: Provide a raw version of the gen9 fast copy blits
lib: Allow the creation of Ys/Yf tiled FBs
testdisplay/skl: Add command line options for Yb/Yf tiled fbs
Tvrtko Ursulin (5):
tests/kms_addfb: Add support for fb modifiers
tests/kms_addfb: Y tiled testcases
tiling: Convert framebuffer helpers to use fb modifiers
lib: Add support for new extension to the ADDFB2 ioctl.
lib/igt_fb: Use new ADDFB2 extension for new tiling modes
Test coverage looks good to me overall, just two minor things:
- functional automated test (replied to the testdisplay patch)
- catching invalid modifiers and making sure y/yf tiling is reject
Will add - not sure how I lost this, I am pretty sure it was there
earlier on.
unconditionally on pre-gen9 seem to be missing too.
ksm_addfb tests for rejecting Y tiling pre gen 9.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
