On Tue, 24 Feb 2015, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Mon, Feb 23, 2015 at 03:15:58PM +0200, Jani Nikula wrote: >> On Mon, 16 Feb 2015, Damien Lespiau <damien.lespiau@xxxxxxxxx> wrote: >> > On Tue, Feb 10, 2015 at 01:15:49PM +0200, Jani Nikula wrote: >> >> skylake_update_primary_plane() did not handle all pixel formats returned >> >> by skl_format_to_fourcc(). Handle alpha similar to skl_update_plane(). >> >> >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89052 >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> >> > >> > Given the discussion with Ville, it's quite likely we'll default to >> > alpha blending for pre-multiplied fbs (for plane supporting alpha), even >> > with the blending properties added. In that context, we can provide a >> > single, fixed, (but useful) blending mode before we get to implement the >> > full thing. So: >> > >> > Reviewed-by: Damien Lespiau <damien.lespiau@xxxxxxxxx> >> >> Pushed to drm-intel-fixes, thanks for the review. > > Well, the patch still isn't quite right. intel_primary_formats_gen4[] > defines which formats the core will let slip through into the driver, > and even with this patch we're not handling them all. Blergh, patches welcome. :p Jani. > > -- > Ville Syrjälä > Intel OTC -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
