-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/11/2015 05:02 AM, Daniel Vetter wrote: > On Wed, Feb 11, 2015 at 1:55 AM, Sean V Kelley <seanvk@xxxxxxxxx> > wrote: >> No corruption seen. I will add reloc domains to my growing audit >> list. > > One more for the libva audit list: > > If you do any ioctl directly, please make sure that you clear the > ioctl structure with memset(&arg, 0, sizeof(arg)); or similar. > Otherwise when we extended them in upstream (which we're just > doing, the kernel 0-fills the new fields automatically) it'll break > because after a recompile there's now garbage in the new fields. > > I just spent a while fixing up libdrm ;-) -Daniel > Cleaned up the hybrid driver. Found numerous instances of the wrong reloc domain assignments, e.g., write_domain of 0. I've since verified it was the root cause of the run 2 run issue. Also cleaned up ioctl and structure clearing. Thanks, Sean -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU57L/AAoJEGScDsMo8QYOFsIQANHSmmYUG5JSqsmewCDO1zHk dh2h56x5oCIooJ2mOh9lcWTRpVbE4uv6HOt6WfThb4dP11Yg5LlOZA1uR65iniIy 9gi2vUotuajm9cOdXKVXCbQBuymR0rKJuRb74e73jk/u5QpOv/zNtThXOG7FfUVu p1DpoVuh8iLGexwAd+6UrCOze5hWfCuh+9t9jTZ8Yr0pgSiRsGClX1mW8vUD4+99 7h5VGonr3tKYqHNZBtneaTcmRkVBtuZ/RBGr5FOnzP1VKIXidgt2t4ID33nZmjsx rJjzQfh408qniBr9L7zIIDUZMiiAucIRm1+4eQ1b+yA9pYkXQfrs/lA9dH80IjAw iWFS+IX7xUCpKZzLB38+dIV/Nsn0nxoF5N1ptz4RMKoeXJVWsRS72jgCjlrE5w4R dnyodU7nlmdcNoeGcDEhcN5Jek7OPYoJLgaC100wu6yDZKJ/2CXJ6XwyORWQ7GU1 UWyqOuam84DJqiwzwkLl6Q9Ur7oC8S8jUIFLqRk/1PZOesu90/yNoJUByLQMMZbl WzUMGdV4D18+uTHhmWGPruCYHLMgRXKVlT/diKH1q5aBOvtP4xeANn+0GSw+E3OZ TN1TGDW/q8U0uN1CDk5hTIDgiJX0Eo9an0CsJ2yZL3K+J56+e6QUY6EPrU/ctqp0 QbT5eI44/dZX2Xmf/kc7 =24vy -----END PGP SIGNATURE----- _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
