On Tue, Feb 10, 2015 at 05:16:13PM +0000, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_sprite.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c > index 0a52c44..9e6f0e5 100644 > --- a/drivers/gpu/drm/i915/intel_sprite.c > +++ b/drivers/gpu/drm/i915/intel_sprite.c > @@ -245,11 +245,11 @@ skl_update_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc, > BUG(); > } > > - switch (obj->tiling_mode) { > - case I915_TILING_NONE: > + switch (fb->modifier[0]) { > + case DRM_FORMAT_MOD_NONE: > stride = fb->pitches[0] >> 6; > break; > - case I915_TILING_X: > + case I915_FORMAT_MOD_X_TILED: > plane_ctl |= PLANE_CTL_TILED_X; > stride = fb->pitches[0] >> 9; > break; > @@ -1076,7 +1076,6 @@ intel_check_sprite_plane(struct drm_plane *plane, > struct intel_crtc *intel_crtc = to_intel_crtc(state->base.crtc); > struct intel_plane *intel_plane = to_intel_plane(plane); > struct drm_framebuffer *fb = state->base.fb; > - struct drm_i915_gem_object *obj = intel_fb_obj(fb); > int crtc_x, crtc_y; > unsigned int crtc_w, crtc_h; > uint32_t src_x, src_y, src_w, src_h; > @@ -1107,9 +1106,9 @@ intel_check_sprite_plane(struct drm_plane *plane, > } > > /* Sprite planes can be linear or x-tiled surfaces */ > - switch (obj->tiling_mode) { > - case I915_TILING_NONE: > - case I915_TILING_X: > + switch (fb->modifier[0]) { > + case DRM_FORMAT_MOD_NONE: > + case I915_FORMAT_MOD_X_TILED: This check here is redundant (framebuffer_init checks this too), so I've removed it. -Daniel > break; > default: > DRM_DEBUG_KMS("Unsupported tiling mode\n"); > -- > 2.2.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx