On Tue, Feb 10, 2015 at 09:36:43PM +0000, Chris Wilson wrote: > On Tue, Feb 10, 2015 at 07:05:44PM +0100, Daniel Vetter wrote: > > Align with common igt library style: > > - Push the igt_require into the function. > > - Push the intel_gen into the function. > > Ugh. intel_gen(intel_get_drm_devid(fd)) is the utmost worst offender > when it comes to polluting tests and debug logs with extra ioctls, > making test bring up harder than it should be. Well I did look at all of them and made sure it's at most a constant factor per subtest. And if you want to fix it the solution imo is certainyl not to cache this everywhere in each test (and complicate them), but in the library. I'll throw a patch for that on top. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
