On Fri, 2015-02-06 at 15:43 +0000, Chris Wilson wrote: > On Fri, Feb 06, 2015 at 08:26:35PM +0530, akash.goel@xxxxxxxxx wrote: > > From: Akash Goel <akash.goel@xxxxxxxxx> > > > > RP Interrupt Up/Down Frequency Limits register (A014) definition > > has changed for SKL. Updated the gen6_rps_limits function as per that > > > > Signed-off-by: Akash Goel <akash.goel@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_pm.c | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 215b200..db24b48 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -3623,7 +3623,7 @@ static void ironlake_disable_drps(struct drm_device *dev) > > * ourselves, instead of doing a rmw cycle (which might result in us clearing > > * all limits and the gpu stuck at whatever frequency it is at atm). > > */ > > -static u32 gen6_rps_limits(struct drm_i915_private *dev_priv, u8 val) > > +static u32 get_rps_limits(struct drm_i915_private *dev_priv, u8 val) > > Spurious name change, it doesn't seem to add anything or clear up any > confusion with vlv. Fine will keep the original name, thought would be better to give a generic name to the function and abstract the platform specific differences inside its definition. > -Chris > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
