On Thu, Feb 05, 2015 at 12:04:27PM +0200, Jani Nikula wrote: > The check for previously reserved stolen space size for FBC in > i915_gem_stolen_setup_compression() did not take the compression > threshold into account. Fix this by storing and comparing to > uncompressed size instead. > > The bug has been introduced in > > commit 5e59f7175f96550ede91f58d267d2b551cb6fbba > Author: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> > Date: Mon Jun 30 10:41:24 2014 -0700 > > drm/i915: Try harder to get FBC > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88975 > Suggested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Ben Widawsky <benjamin.widawsky@xxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx # 3.17+ > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> Thanks, I think uncompressed_size clarifies exactly what we want to compare against (is this allocation request any bigger or smaller than the last request). Then if we need the final size for anything we can add it without further confusion. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
