On Wed, Jan 28, 2015 at 02:43:24PM +0200, Mika Kuoppala wrote: > intel_uncore_early_sanitize() will reset the forcewake registers. When > forcewake domains were introduced, the domain init was done after the > sanitization of the forcewake registers. And as the resetting of > registers use the domain accessors, we tried to reset the forcewake > registers with unitialized forcewake domains and failed. > > Fix this by sanitizing after all the domains have been initialized. Do > per domain clearing of forcewake register on domain init so that > IVB can do early access to ECOBUS do determine the final configuration. > > This regression was introduced in > > commit 05a2fb157e44a53c79133805d30eaada43911941 > Author: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx> > Date: Mon Jan 19 16:20:43 2015 +0200 > > drm/i915: Consolidate forcewake code > > v2: Carve out ellc detect, fw_domain_reset for ivb/ecobus (Chris) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88805 > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Reported-by: Olof Johansson <olof@xxxxxxxxx> > Tested-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx> (v1) > Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> Looks good to me, I hope it survives booting... Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
