On Tue, Jan 20, 2015 at 08:37:21AM +0530, Deepak S wrote: > > On Monday 19 January 2015 03:14 PM, Daniel Vetter wrote: > >On Fri, Jan 16, 2015 at 08:42:16PM +0530, deepak.s@xxxxxxxxxxxxxxx wrote: > >>From: Deepak S <deepak.s@xxxxxxxxxxxxxxx> > >> > >>Starting with Cherryview, devices may have a varying number of EU for > >>a given ID due to creative fusing. Punit support different frequency for > >>different fuse data. We use this patch to help get total eu enabled and > >>read the right offset to get RP0 > >> > >>Based upon a patch from Jeff, but reworked to only store eu_total and > >>avoid sending info to userspace > >> > >>v2: Format register definitions (Jani) > >> > >>Signed-off-by: Deepak S <deepak.s@xxxxxxxxxxxxxxx> > >>Signed-off-by: Jeff McGee <jeff.mcgee@xxxxxxxxx> > >This isn't really how sob works. The last line _must_ be the person who > >last touched the patch, otherwise you're doing it wrong. Since this patch > >doesn't seem to be from Jeff I've dropped his sobline and converted to an > >ack. > > > >Really if you just want to acknowledge people who have contributed to a > >patch (e.g. you've based your patch on some version of theirs) do that in > >the commit message + Cc: > >-Daniel > > Oh Sorry. I was not aware of this. I will follow the guidelines in future patch submission. Yeah I think most examples of sob abuse come from vpg display, so updating your guidelines would be good. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
