On Wed, Jan 14, 2015 at 11:10:54AM +0530, Sonika Jindal wrote: > Taking rotation into account while checking the plane > and adjusting the sizes accordingly. > > v2: Adding parameter in the callers in the same patch(Matt) > Removing unnecessary code and allowing scaling(Ville) > > Signed-off-by: Sonika Jindal <sonika.jindal@xxxxxxxxx> > --- ... > EXPORT_SYMBOL(drm_plane_helper_check_update); > @@ -258,7 +293,8 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, > &src, &dest, &clip, > DRM_PLANE_HELPER_NO_SCALING, > DRM_PLANE_HELPER_NO_SCALING, > - false, false, &visible); > + false, false, &visible, > + DRM_ROTATE_0); I think this needs to be BIT(DRM_ROTATE_0)? ... > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index e7ca25b..4813a53 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -551,7 +551,8 @@ static int vop_update_plane_event(struct drm_plane *plane, > &src, &dest, &clip, > DRM_PLANE_HELPER_NO_SCALING, > DRM_PLANE_HELPER_NO_SCALING, > - can_position, false, &visible); > + can_position, false, &visible, > + DRM_ROTATE_0); Same here. Matt -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx