On Tue, Dec 16, 2014 at 12:32:30PM +0000, Nick Hoath wrote: > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index d68c75f..114adc3 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2036,6 +2036,30 @@ struct drm_i915_gem_request { > struct list_head client_list; > > uint32_t uniq; > + > + /** > + * The ELSP only accepts two elements at a time, so we queue > + * context/tail pairs on a given queue (ring->execlist_queue) until the > + * hardware is available. The queue serves a double purpose: we also use > + * it to keep track of the up to 2 contexts currently in the hardware > + * (usually one in execution and the other queued up by the GPU): We > + * only remove elements from the head > + * of the queue when the hardware informs us that an element has been > + * completed. > + * > + * All accesses to the queue are mediated by a spinlock > + * (ring->execlist_lock). > + */ > + > + /** Execlist link in the submission queue.*/ > + struct list_head execlist_link; > + > + /** Execlists workqueue for processing this request in a bottom half */ > + struct work_struct work; Hm I've thought this would drop out with the other rework we've had floating around. It's also not used anywhere, so I guess it disappeared for real and is just a leftover from rebasing? Otherwise I guess this is ready for final review I think. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx