On Tue, Dec 16, 2014 at 05:39:19PM +0530, Deepak S wrote: > > On Friday 12 December 2014 10:04 PM, Ville Syrjälä wrote: > >On Sat, Dec 13, 2014 at 11:43:27AM +0530, deepak.s@xxxxxxxxxxxxxxx wrote: > >>From: Deepak S <deepak.s@xxxxxxxxxxxxxxx> > >> > >>Higher RC6 residency is observed using timeout mode > >>instead of EI mode. It's Recommended to use TO Method for RC6. > >> > >>v2: Add comment about timeout threshold. (Tom) > >Yeah if TO is better let's just use it. The 1750us value is what > >the BIOS spec recommends, so: > > > >Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > >>Signed-off-by: Deepak S <deepak.s@xxxxxxxxxxxxxxx> > >>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > >Why is Rodrigo's sob here? > > Rodrigo had resubmitted my patch with his sob. just retained :) Sob should document the path a patch took, not every possible person who every touch a patch. If you want to acknowledge indirect contributions just mention them in the commit message (E.g. "based on a patch by" or "squash in fixup from $person"). The bangalore team like to pile up sob lines especially, which isn't really how it's supposed to work. A few things to check: - First sob should be the original author. - Last sob should be the submitter of the patch. Anyway, back to merging patches for me ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
