Re: [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 12, 2014 at 11:43:55AM +0000, Thomas Wood wrote:
> On 12 December 2014 at 10:18,  <tim.gore@xxxxxxxxx> wrote:
> > From: Tim Gore <tim.gore@xxxxxxxxx>
> >
> > intel_sprite_on wont build on Android, due to use
> > of a particular API that has changed in Gmin
> >
> > Signed-off-by: Tim Gore <tim.gore@xxxxxxxxx>
> > ---
> >  demos/Android.mk | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/demos/Android.mk b/demos/Android.mk
> > index 6227e06..be7f3c2 100644
> > --- a/demos/Android.mk
> > +++ b/demos/Android.mk
> > @@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
> >
> >  include $(CLEAR_VARS)
> >
> > -LOCAL_SRC_FILES := intel_sprite_on.c
> > +# This demo wont build on android (from Gmin on).
> > +#LOCAL_SRC_FILES := intel_sprite_on.c
> > +
> >
> >  LOCAL_CFLAGS += -DHAVE_TERMIOS_H
> >  LOCAL_CFLAGS += -DANDROID -UNDEBUG
> > -LOCAL_CFLAGS += -std=c99
> > +LOCAL_CFLAGS += -std=gnu99
> 
> I think this change should have been in your previous patch
> ("Android.mk: replace std=c99 with std=gnu99")?

btw intel_sprite_on has been contributed by your team (Armin Reese), so
not sure why you want to disable it. Have you checked with display folks
whether they don't need it?
-Daniel

> 
> 
> >  # Excessive complaining for established cases. Rely on the Linux version warnings.
> >  LOCAL_CFLAGS += -Wno-sign-compare
> >
> > --
> > 2.1.3
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux