On Thu, Dec 11, 2014 at 05:03:46PM +0000, Tvrtko Ursulin wrote: > > Hi, > > I'll try to do the detailed review of your series in the following few days. > I might ask some questions on the design also to help me understand the > bigger picture. > > First thing, I see that patches are checkpatch.pl clean, apart when run in > strict mode. I think Daniel prefers "--strict" nowadays, at least I needed > to fix up those in my patches so you should probably do the same. Well I mostly run --strict since that checks for the alignment of continuation lines for function parameters. Imo not following the i915 coding style for that looks a bit too jarring ;-) Still checkpatch is just a tool and occasionally seriously lacks taste, so please use --strict wisely instead of strictly. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
