On Wed, Dec 10, 2014 at 03:07:07PM +0000, Dave Gordon wrote: > When adding instructions to a legacy or LRC ringbuffer, the sequence of > emit() calls must be preceded by a call to intel(_logical)_ring_begin() > to reserve the required amount of space, and followed by a matching call > to intel(_logical)_ring_advance(). Historically some (display) code > didn't use begin/advance, but just inserted instructions ad hoc, which > would then be sent to the hardware along with the current or next batch, > but this is not supported and is now regarded as incorrect. > > This commit therefore adds begin/advance tracking, with WARNings where > various forms of misuse are detected. Please review the suggested approach I made months ago which avoid all this ad hoc hilarity. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
