On Thu, Dec 04, 2014 at 09:48:11AM +0000, Chris Wilson wrote: > On Wed, Dec 03, 2014 at 02:59:24PM +0000, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > > > Multiple GGTT VMAs per object will be introduced in the near future which will > > make it impossible to guarantee normal GGTT view is at the head of the list. > > > > Purpose of this patch is to break this assumption straight away so any > > potential hidden assumptions in the code base can be bisected to this > > simple patch. > > No, please don't. The rationale for putting ggtt first is because it > puts the one vma that every object is likely to use at the front, and > makes it also the first in the list for debugging. With hindsight I think this was just premature optimization (and way too many obj->vma lookups to boot). Imo we should just fix the remaining spurious obj->vma lookups we have and if there's still a problem then we need to have actual benchmark data or profiles to support this trick. Hence I pulled this patch in, thanks. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
