Re: [PATCH 2/5] drm/i915: s/intel_workarouns_ring/intel_render_workarounds/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 27, 2014 at 03:07:28PM +0000, Dave Gordon wrote:
> On 19/11/14 23:33, Daniel Vetter wrote:
> > Since it's not for the rings but engine, and its specifically for
> > render state and workarounds.
> > 
> > Note that there's a massive s/ring/engine/ required all over the
> > driver, but that's really not part of this patch here. So I've leaft
> > the paramter names as-is.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
> 
> Code is fine, but the commit message contains several typos.
> s/leaft/left/ and s/paramter/parameter/ don't really matter,
> but the one in the subject line is a bit more important.
> It should be "s/init_workarounds_ring/init_render_workarounds/",
> with no mention of "intel_" !
> 
> Once that's corrected, then
> 
> Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx>

Well I've decided to drop this one since like Chris mentioned there's a
bit a mess here with different callbacks doing different parts of the ring
ctx init. And it kinda doesn't make sense to bikeshed names while we still
have a bigger confusion.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux