Re: [PATCH 4/5] drm/i915: Only init engines once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/11/14 23:33, Daniel Vetter wrote:
> We can do this.
> 
> And now there's finally the clean split between software setup and
> hardware setup I kinda wanted since multi-ring support was merged
> aeons ago. It only took almost 5 years.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_gem.c         | 13 ++++++++++---
>  drivers/gpu/drm/i915/intel_lrc.c        |  6 ------
>  drivers/gpu/drm/i915/intel_ringbuffer.c |  4 ----
>  3 files changed, 10 insertions(+), 13 deletions(-)

Yep, that's what I was hoping for :)

Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx>

(Mind you, I like Chris's suggestions too, especially converting all the
historical /ring/ to the more accurate /engine/).

> Can I humbly suggest:
>
>
http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/i915_gem.c#n4464
>
http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/i915_gem.c#n4394
> -Chris




_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux