On 11/26/2014 11:38 PM, Daniel Vetter wrote:
On Wed, Nov 26, 2014 at 10:50:46PM +0530, Singh, Gaurav K wrote:
This patch has some style issues. Please address them.
Please be more specific, that's rather non-actionable review.
Also general rule of thumb is that if it doesn't look offensive and the
patch is otherwise good it still deserves an r-b. I can easily fix up
small things while applying (and do that all the time).
-Daniel
checkpatch.pl is throwing few warnings and one error which are mainly
because of lines more than 80 characters. The patch is otherwise
looking good. I will add Reviewed-by field in the patch.
with regards,
Gaurav
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
