On Mon, Nov 24, 2014 at 06:49:43PM +0000, John.C.Harrison@xxxxxxxxx wrote: > From: John Harrison <John.C.Harrison@xxxxxxxxx> > > The ring member of the object structure was always updated with the > last_read_seqno member. Thus with the conversion to last_read_req, obj->ring is > now a direct copy of obj->last_read_req->ring. This makes it somewhat redundant > and potentially misleading (especially as there was no comment to explain its > purpose). > > This checkin removes the redundant field. Many uses were simply testing for > non-null to see if the object is active on the GPU. Some of these have been > converted to check 'obj->active' instead. Others (where the last_read_req is > about to be used anyway) have been changed to check obj->last_read_req. The rest > simply pull the ring out from the request structure and proceed as before. > > For: VIZ-4377 > Signed-off-by: John Harrison <John.C.Harrison@xxxxxxxxx> > Reviewed-by: Thomas Daniel <Thomas.Daniel@xxxxxxxxx> Ok merged up to this for now. I'd like to settle things a bit first (and also figure out what to do with the trace_irq stuff). Thanks for patches&review, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
