On Mon, Nov 24, 2014 at 5:56 PM, Egbert Eich <eich@xxxxxxx> wrote: > Before testing if the panel VDD is enabled on eDP cancel any pending > disable worker. This makes sure the worker doesn't fire when we expect > VDD to be enabled. > > https://bugs.freedesktop.org/show_bug.cgi?id=86201 > > Signed-off-by: Egbert Eich <eich@xxxxxxx> This shouldn't be needed at all: - The vdd off rechecks ->want_panel_vdd under the pps lock. - The off function sets that and also reschedules the work (to make sure it doesn't kill vdd to early) again all under the same lock. So no one can sneak in and the work racing with us isn't an issue. Or shouldn't be at least. So if this helps we need to dig a bit deeper. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
