>-----Original Message----- >From: Rodrigo Vivi [mailto:rodrigo.vivi@xxxxxxxxx] >Sent: Thursday, November 20, 2014 10:55 PM >To: Vivi, Rodrigo; R, Durgadoss; Zanoni, Paulo R; Daniel Vetter >Cc: intel-gfx >Subject: Re: [PATCH 15/15] drm/i915: Enable PSR for Baytrail and Braswell. > >Daniel, I think this is the only one of this series with pending >reviewed-by right? > >Durga or Paulo, could you please help me on this? > >Thank you, >Rodrigo. > >On Fri, Nov 14, 2014 at 8:52 AM, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: >> This patch is the last in series of VLV/CHV PSR, >> that finnaly enable psr by adding it to HAS_PSR Finally, >> and calling the proper enable and disable >> functions on the right places. >> >> Although it is still disabled by default. >> >> v2: Rebase over intel_psr and merge Durgadoss's fixes. >> >> Cc: Durgadoss R <durgadoss.r@xxxxxxxxx> >> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> With that, Reviewed-by: Durgadoss R <durgadoss.r@xxxxxxxxx> Thanks, Durga >> --- >> drivers/gpu/drm/i915/i915_drv.h | 3 ++- >> drivers/gpu/drm/i915/intel_dp.c | 4 ++++ >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h >> index 573f084..4020653 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.h >> +++ b/drivers/gpu/drm/i915/i915_drv.h >> @@ -2267,7 +2267,8 @@ struct drm_i915_cmd_table { >> >> #define HAS_DDI(dev) (INTEL_INFO(dev)->has_ddi) >> #define HAS_FPGA_DBG_UNCLAIMED(dev) (INTEL_INFO(dev)->has_fpga_dbg) >> -#define HAS_PSR(dev) (IS_HASWELL(dev) || IS_BROADWELL(dev)) >> +#define HAS_PSR(dev) (IS_HASWELL(dev) || IS_BROADWELL(dev) || \ >> + IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev)) >> #define HAS_RUNTIME_PM(dev) (IS_GEN6(dev) || IS_HASWELL(dev) || \ >> IS_BROADWELL(dev) || IS_VALLEYVIEW(dev)) >> #define HAS_RC6(dev) (INTEL_INFO(dev)->gen >= 6) >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index 98f7ecd..d53a0c9 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -2075,6 +2075,9 @@ static void intel_disable_dp(struct intel_encoder *encoder) >> if (crtc->config.has_audio) >> intel_audio_codec_disable(encoder); >> >> + if (HAS_PSR(dev) && !HAS_DDI(dev)) >> + intel_psr_disable(intel_dp); >> + >> /* Make sure the panel is off before trying to change the mode. But also >> * ensure that we have vdd while we switch off the panel. */ >> intel_edp_panel_vdd_on(intel_dp); >> @@ -2299,6 +2302,7 @@ static void vlv_enable_dp(struct intel_encoder *encoder) >> struct intel_dp *intel_dp = enc_to_intel_dp(&encoder->base); >> >> intel_edp_backlight_on(intel_dp); >> + intel_psr_enable(intel_dp); >> } >> >> static void g4x_pre_enable_dp(struct intel_encoder *encoder) >> -- >> 1.9.3 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > >-- >Rodrigo Vivi >Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
