On Thu, Nov 20, 2014 at 12:25 PM, Daniel, Thomas <thomas.daniel@xxxxxxxxx> wrote: >> -----Original Message----- >> From: Chris Wilson [mailto:chris@xxxxxxxxxxxxxxxxxx] >> Sent: Thursday, November 20, 2014 11:16 AM >> To: Daniel, Thomas >> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; akash-goels@xxxxxxxxx >> Subject: Re: [PATCH] drm/i915: Don't pin LRC in GGTT when >> dumping in debugfs >> >> On Thu, Nov 20, 2014 at 11:12:05AM +0000, Thomas Daniel wrote: >> > LRC object does not need to be mapped into the GGTT when dumping. Just >> > use pin_pages. A side-effect of this patch is that a compiler warning >> > goes away (not checking return value of i915_gem_obj_ggtt_pin). >> >> Please explain why you need to pin the pages. > I suppose I don't as this is protected by the struct mutex and unpin is called before returning. Hm right a simple call to i915_gem_object_get_pages should be all that's needed to get at the pages list. Sorry for the misadvise on the internal mail. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
