Re: [PATCH 1/4] drm/i915: No-Op enter/leave vt gem ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 19, 2014 at 08:36:47PM +0100, Daniel Vetter wrote:
> We've killed ums support by now, it's time to reap the benefits. This
> one here is getting in the way of doing some ring init cleanup.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>

1-3 seem reasonable and we've established that no one cried out for UMS
in the last and pending kernel release, so

Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Patch 4 seems incomplete. You remove one part of the DRI1 implmentation,
but I don't see how that prevents the DRI1 ioctls then promptly blowing
up instead of reporting an error back to the user.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux