Re: [PATCH 15/15] drm/i915: Enable PSR for Baytrail and Braswell.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 14, 2014 at 08:52:41AM -0800, Rodrigo Vivi wrote:
> This patch is the last in series of VLV/CHV PSR,
> that finnaly enable psr by adding it to HAS_PSR
> and calling the proper enable and disable
> functions on the right places.
> 
> Although it is still disabled by default.
> 
> v2: Rebase over intel_psr and merge Durgadoss's fixes.
> 
> Cc: Durgadoss R <durgadoss.r@xxxxxxxxx>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

where's the patch to enable PSR by default again? Also I've heard noises
that the sink crc stuff is busted :( And we still have the tasklist to fix
up the functional igt testcases.

I don't want to block merging this, but we need a clear task list of
what's left to do and full commitment of the necessary engineer-time to
actually make it happen. PSR with the frontbuffer tracking code is
invasive and will simply keep on bitrotting if we don't enable it (atomic
modeset already almost broke it completely by accident), which would
really be sad given all the time we've invested. Please chat with
Paul/Gavin to make sure this is tracked.

I don't want to carry essentially dead code around - the illusion that it
will get magically rebased and keep working is really just that.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux