On Thu, Nov 13, 2014 at 08:02:43PM +0800, Yu Zhang wrote: > + if (low_gm_base < ggtt_vm->start > + || low_gm_end > dev_priv->gtt.mappable_end > + || high_gm_base < dev_priv->gtt.mappable_end > + || high_gm_end > ggtt_vm_end) { Nit: Logical operators like || or && should be at the end of the previous line, not at the beginning of the new line. checkpatch would have noticed this one. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx