On Wed, Nov 05, 2014 at 12:13:40PM +0200, Mika Kuoppala wrote: > Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> writes: > > > On Wed, Nov 05, 2014 at 10:18:46AM +0200, Mika Kuoppala wrote: > >> Don't rush into getting new fw until the clearing > >> of old one has been acked. > >> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85684 > >> Tested-by: lu hua <huax.lu@xxxxxxxxx> > >> Signed-off-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxx> > > > > This is just a revert of > > commit 5cb13c07dae73380d8b3ddc792740487b8742938 > > Author: Deepak S <deepak.s@xxxxxxxxxxxxxxx> > > Date: Thu Sep 18 18:51:50 2014 +0530 > > > > drm/i915/vlv: Remove check for Old Ack during forcewake > > > > except you left the comment behind. > > I failed at archeology. There is even nice comment from Deepak on > top I managed to miss. > > But after reading this comment and the workaround description, I > think that this WaRsDontPollForAckOnClearingFWBits is not valid for > our use case. > > We use only one bit per engine, so our use case is not multithreaded > in that sense. Since this is a regression I prefer we apply the revert and then dig deeper. Mika, can you pls resend as a proper revert? Except ofc when we have a solution right now, too. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
