Re: [PATCH] drm/i915: Reject modeset when the same digital port is used more than once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 04, 2014 at 10:50:55AM -0200, Paulo Zanoni wrote:
> 2014-11-03 8:29 GMT-02:00 Daniel Vetter <daniel@xxxxxxxx>:
> >> If we're also interested on DDI platforms, we need to check for
> >> INTEL_OUTPUT_UNKNOWN here too. I guess Daniel could add this while
> >> applying the patch...
> >
> > Adding UNKNOWN here smells like a massive hack.
> 
> Why?

Someone will reuse UNKOWN for something else than DDI.
> 
> > Can't we add a new
> > OUTPUT_DDI type, which together with the ddi personality stuff dtrt?
> 
> Or we can rename INTEL_OUTPUT_UNKNOWN to INTEL_OUTPUT_DDI_DISCONNECTED
> so it smells less hacky to you?

Yeah that works, too.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux