On Thu, Oct 30, 2014 at 04:39:37PM +0000, Tvrtko Ursulin wrote: Just a sideline comment here for now ;-) > +/* intel_dma.c */ > +int i915_st_set_pages(struct sg_table **st, struct page **pvec, int num_pages); Comments all over should tell you that i915_dma.c is super legacy territory and really you should never touch it. I think i915_gem.c is a better place. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx