Re: [PATCH 0/8] Skylake primary plane read-out

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 29, 2014 at 05:22:39PM +0000, Damien Lespiau wrote:
> Skylake changed a few things here and there in the plane registers and we
> weren't correctly reading out the primary plane state when trying to re-use the
> BIOS stolen allocated fb (especially the stride was all wrong). Of course,
> weird artefacts ensued when loading the driver.
> 
> This series implement get_plane_config() for SKL, preceded  by a few clean-up
> patches. No artefacts when loading the driver anymore, at least on this end.
> 
> Damien Lespiau (8):
>   drm/i915: Change plane_config to store a tiling_mode
>   drm/i915: Use a common function for computing the fb height alignment
>   drm/i915: Unclutter the get_plane() functions
>   drm/i915: Don't use crtc->plane in ILK+ get_config()
>   drm/i915: Use pipe_name() in the get_plane_config() functions
>   drm/i915: Make intel_format_to_fourcc() static
>   drm/i915/skl: intel_format_to_fourcc() doesn't work for SKL planes
>   drm/i915/skl: Provide a Skylake version of get_plane_config()

Since you noodle around in this area: Feel like throwing an
s/plane_config/initial_plane_config/ at (v)funcs and structs in this area?

We're already growing a proper plane_config struct for atomic modesets,
and it's getting confusing ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux