On Tue, Nov 04, 2014 at 02:20:38PM +0530, Gagandeep S Arora wrote:
> +/*
> + * The macros and structures inside the conditional statement
> + * #if (ANDROID_HAS_CAIRO == 1) are defined in lib/igt_kms.c
> + * when the flag ANDROID_HAS_CAIRO is 1.
> + */
> +#if (ANDROID_HAS_CAIRO == 0)
> +struct type_name {
> + int type;
> + const char *name;
> +};
Imo just really get cairo going on Android. This kind of duplication isn't
good.
Or if you can't, extract the cairo-dependent part of igt_kms.c into
igt_cairo.c source files. But not copypasting.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
