Re: [PATCH i-g-t 2/2] lib/igt_core.h: add debug messages for test requirements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 29, 2014 at 03:20:47PM +0000, Thomas Wood wrote:
> @@ -380,6 +382,7 @@ void igt_exit(void) __attribute__((noreturn));
>   */
>  #define igt_require_f(expr, f...) do { \
>  	if (!(expr)) igt_skip_check(#expr , f); \
> +	else igt_debug("Test requirement passed: "#expr"\n"); \
>  } while (0)
>  
>  /**
> @@ -398,6 +401,7 @@ void igt_exit(void) __attribute__((noreturn));
>   */
>  #define igt_skip_on_f(expr, f...) do { \
>  	if ((expr)) igt_skip_check("!("#expr")", f); \
> +	else igt_debug("Test requirement passed: !("#expr")\n"); \

Hm, for the the _f variants, should we also print the format string? Often
I use that one when it's not clear what precise requirement failed from
the test alone. Or is the resulting output too confusing?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx





[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux