On Mon, Nov 03, 2014 at 01:15:24PM +0100, Daniel Vetter wrote:
> On Tue, Oct 28, 2014 at 04:30:41PM +0200, Ville Syrjälä wrote:
> > On Tue, Oct 28, 2014 at 11:26:51AM -0200, Paulo Zanoni wrote:
> > > >> + /*
> > > >> + * We can't change the DDI type if we already have a connected
> > > >> + * device on this port. The first time a DDI is used though
> > > >> + * (encoder_type is INTEL_OUTPUT_UNKNOWN) and we force a
> > > >> + * connector to be connected (either trought the kernel command
> > > >> + * line or KMS) we need to comply.
> > > >> + */
> > > >> + if (encoder->type != INTEL_OUTPUT_UNKNOWN &&
> > > >> + connector->base.status == connector_status_connected) {
> > > >> + DRM_DEBUG_KMS("Can't set DDI %c personality to %s, it has a connected %s device\n",
> > > >> + port_name(port),
> > > >> + intel_output_name(encoder->type),
> > > >> + intel_output_name(pipe_config->ddi_personality));
> > > >> + return false;
> > > >> + }
> > > >
> > > > I think this part is better done with Ville's more general "do we have
> > > > both hdmi and dp on the same dig_port?" check. Care to review Ville's
> > > > patch instead? Thomas Wood is signed up for it on the review board but I
> > > > guess you can steal that task.
> > >
> > > Ville's patch solves a different problem. I just reviewed it, but we
> > > still need the check above. The code above is in case, for example,
> > > there's a DP connector actually connected (but without a mode set),
> > > and then the user tries to set a mode on the HDMI connector of this
> > > encoder.
>
> My comment was _only_ about the check quoted above, the other part of the
> loop is imo the entire point of adding ddi_personality.
Ok, misunderstood what this does - I've thought it's just checking that we
don't use both hdmi and DP on the same ddi encoder. Imo that's all we need
to check really.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
